LPD-68814 Lower log level #5137
Conversation
The ERROR level was breaking some CI tests because PortletRenderUtil is logging the message when it cannot find a CSS file. We used error because we assumed all CSS files requested by that class should exist, but in the case of tests, they don’t. Now we lower the log message to DEBUG because the tokenized feature is only used for legacy code and if a CSS file that has tokens cannot be found by PortletRenderUtil and it ends up causing a visible error, it should be a fairly straightforward process to diagnose it, activating the traces if necessary. (see https://liferay.atlassian.net/browse/LPD-68304?focusedCommentId=30544639)
|
CI is automatically triggering the following test suites:
|
|
Test suite sf has been triggered on http://test-1-33 |
|
ci:forward |
|
Test suite relevant has been triggered on http://test-1-33 |
|
Test suite sf has been triggered on http://test-1-33 |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesRan com.liferay.source.formatter at released version 1.0.1545. Click here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-68814 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#4445 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#5137 Testray Routine:EE Pull Request Testray Build ID: 341667620Testray Importer:test-portal-source-format#4445 |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - success
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesRan com.liferay.source.formatter at released version 1.0.1545. Click here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-68814 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#4446 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#5137 Testray Routine:EE Pull Request Testray Build ID: 341667624Testray Importer:test-portal-source-format#4446 |
✔️ ci:test:stable - 11 out of 11 jobs passed❌ ci:test:relevant - 21 out of 49 jobs passed in 2 hours 37 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 2018e7596b60007f382316cc000ce88d1994c6fa ci:test:stable - 11 out of 11 jobs PASSED11 Successful Jobs:ci:test:relevant - 21 out of 49 jobs PASSED28 Failed Jobs:
21 Successful Jobs:For more details click here.Failures unique to this pull:
For upstream results, click here.Test bundle downloads: |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#8500 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#5137 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - izaera > liferay-frontend - PR#5137 - 2025-10-17[02:54:04] Testray Build ID: 341836610Testray Importer:test-portal-acceptance-pullrequest(master)#8500 |
|
ci:forward |
|
Test suite relevant has been triggered on http://test-1-26 |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites:
|
liferay-continuous-integration
added
ci:test:relevant - pending
and removed
ci:test:relevant - failure
labels
|
ci:forward |
|
Test suite relevant has been triggered on http://test-1-35 |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites:
|
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#7666 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#5137 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - izaera > liferay-frontend - PR#5137 - 2025-10-19[23:02:55] Testray Build ID: 342638081Testray Importer:test-portal-acceptance-pullrequest(master)#7666 |
|
ci:report:342638081 |
|
Test suite default has been triggered on http://test-1-36 |
Build completed.Testray CSV has been generated successfully for testrayBuildID: 342638081. Job Link: generate-testray-csv Testray CSV Link: testray-results-342638081.csv |
liferay-continuous-integration
added
ci:test - success
and removed
ci:test - pending
labels
|
Failures don't seem related to the PR |
|
ci:forward:force |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously completed test suites:
|
|
Test suite default has been triggered on http://test-1-30 |
|
All required test suite(s) completed. |
|
Pull request has been successfully forwarded to brianchandotcom#166813 |
2 participants
The ERROR level was breaking some CI tests because PortletRenderUtil is logging the message when it cannot find a CSS file. We used error because we assumed all CSS files requested by that class should exist, but in the case of tests, they don’t.
Now we lower the log message to DEBUG because the tokenized feature is only used for legacy code and if a CSS file that has tokens cannot be found by PortletRenderUtil and it ends up causing a visible error, it should be a fairly straightforward process to diagnose it, activating the traces if necessary.
(see https://liferay.atlassian.net/browse/LPD-68304?focusedCommentId=30544639)